Fix fiat_test_alltoallv #81
Merged
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
That's great @DJDavies2 thanks for this! |
Contributor
Author
|
I have run it with other compilers and it seems fine, but I'm not sure if I can get NAG to use the f08 version. |
wdeconinck
approved these changes
Jan 26, 2026
Collaborator
Thanks, that could always come later then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this fixes #80.
The problem here is that there are pointers that are becoming undefined because they are being associated with something that does not have the target attribute. This can happen like this:
integer :: a
integer, pointer :: b
call sub(a,b)
....
subroutine sub(a,b)
integer, target :: a
integer,pointer :: b
b => a
end subroutine sub
The pointer assignment in sub is valid. However when sub returns it is not valid to assume that b is associated with a in the calling routine because a does not have the target attribute in the calling rouitne; b becomes undefined.
I have added the target attributes where necessary to get this test to work.